Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return only complete codesystem concepts #63

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

velramiir
Copy link
Contributor

@velramiir velramiir commented Sep 26, 2023

Ticket 🎫

This closes #60.

Description 📖

This filters the search results for presence of the properties code and display and logs a warning if incomplete concepts are found.

How to Test? 🧪

Remove a code or a display property from the ICD-10 CodeSystem and search for this code. It should not appear in the search results anymore. A warning should be logged by the API.

Checklist ✅

  • My changes generate no new warnings
  • Made corresponding changes to the documentation if applicable
  • Commented my code, particularly in hard-to-understand areas if applicable
  • Performed a self-review of my own changes

@velramiir velramiir linked an issue Sep 26, 2023 that may be closed by this pull request
2 tasks
@dotbase-bot dotbase-bot self-assigned this Sep 26, 2023
@dotbase-bot dotbase-bot requested a review from a team September 26, 2023 14:56
@dotbase-bot dotbase-bot added this to the next milestone Sep 26, 2023
@velramiir velramiir force-pushed the feat/only-complete-codesystem-concepts branch from 698cabe to 3afa7b8 Compare September 27, 2023 11:19
@velramiir velramiir marked this pull request as ready for review September 27, 2023 11:21
Copy link
Contributor

@andreakreichgauer andreakreichgauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@dotbase-bot dotbase-bot requested a review from a team September 27, 2023 12:16
@dotbase-bot dotbase-bot merged commit 0433ad1 into dev Sep 27, 2023
@dotbase-bot dotbase-bot deleted the feat/only-complete-codesystem-concepts branch September 27, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response should only contain correct items with code and display
3 participants